Fix undo for edges #952
Merged
Fix undo for edges #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change should fix the undo of edges in the model. Both when deleting a node with connected edges and a single edge.
Here is the undo behavior before this change (on the public website):
orig_small.mp4
Here is the undo behavior after this change (locally hosted):
fixed_small.mp4
Description for the changelog:
Register Edges in the x6 model instead of registering Edges as Nodes.
Other info:
Closes #428
Line 14 might need a similar change, but I am not familiar with the compatibility concerns.